Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two benefits:
from_timestamp_millis
function (which had the property thatNaiveDateTime::from_timestamp_millis(-1000)
did not compare equal toNaiveDateTime::from_timestamp_opt(-1, 0)
. It has been fixed in the latest Chrono.from_timestamp_micros
function introduced in Add from_timestamp_micros function chronotope/chrono#906 , rather than duplicating this error-prone logic in our own codebase.Once Chrono does another release of 0.4.x, we can stop depending on HEAD.
Motivation
See initial section
Tips for reviewer
Checklist
This PR has adequate test coverage / QA involvement has been duly considered.
This PR evolves an existing
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-proto
label.This PR includes the following user-facing behavior changes:
None