Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to HEAD of Chrono 0.4.x #16702

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Conversation

umanwizard
Copy link
Contributor

This has two benefits:

  1. We will no longer risk calling the old, buggy from_timestamp_millis function (which had the property that NaiveDateTime::from_timestamp_millis(-1000) did not compare equal to NaiveDateTime::from_timestamp_opt(-1, 0). It has been fixed in the latest Chrono.
  2. We will be able to use the from_timestamp_micros function introduced in Add from_timestamp_micros function chronotope/chrono#906 , rather than duplicating this error-prone logic in our own codebase.

Once Chrono does another release of 0.4.x, we can stop depending on HEAD.

Motivation

See initial section

Tips for reviewer

Checklist

Copy link
Member

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed the missing comma in deny.toml and marked for automerge.

@benesch benesch enabled auto-merge (rebase) December 17, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants