Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/user document reserved disk_bytes fields in usage tables #18743

Merged
merged 1 commit into from
Apr 19, 2023
Merged

doc/user document reserved disk_bytes fields in usage tables #18743

merged 1 commit into from
Apr 19, 2023

Conversation

guswynn
Copy link
Contributor

@guswynn guswynn commented Apr 12, 2023

Documenting #18717, should merge after that pr is released

Motivation

docs

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@guswynn guswynn requested a review from a team as a code owner April 12, 2023 17:29
tr0njavolta
tr0njavolta reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@tr0njavolta tr0njavolta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense. The only suggestion I have is to flip the statement so what the user will see is first.

Currently null. Reserved for future use.

@morsapaes morsapaes mentioned this pull request Apr 19, 2023
Merged
@morsapaes morsapaes merged commit d2f9005 into MaterializeInc:main Apr 19, 2023
def- pushed a commit to def-/materialize that referenced this pull request Apr 19, 2023
@guswynn @def-
doc/user document reserved disk_bytes fields in usage tables (Materia…
d7b208b 
…lizeInc#18743)
@materialize-bot materialize-bot mentioned this pull request Apr 21, 2023
Closed
12 tasks
@guswynn guswynn deleted the disk-usage-docs branch April 26, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tr0njavolta tr0njavolta tr0njavolta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guswynn @tr0njavolta @morsapaes