adapter: Update ObjectId to handle catalog schema #18762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the ObjectId enum so that it can be used for catalog schemas.
maddyblue
reviewed
Apr 13, 2023
| @@ -319,7 +319,7 @@ pub struct RevokeRoleV1 { | |||
| pub struct SchemaV1 { | |||
| pub id: String, | |||
| pub name: String, | |||
| pub database_name: String, | |||
| pub database_name: Option<String>, | |||
There was a problem hiding this comment.
The intention was that changes of this form would require making a SchemaV2: update all current creators to produce v2s, but the v1 struct could still be read off disk.
There was a problem hiding this comment.
Just updated this to use a V2
maddyblue
approved these changes
Apr 13, 2023
…ect-id-schemas # Conflicts: # src/adapter/src/catalog.rs # src/adapter/src/catalog/storage.rs # src/adapter/src/rbac.rs
umanwizard
force-pushed
the
object-id-schemas
branch
2 times, most recently
from
e3867f6
to
a51aeb5
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the ObjectId enum so that it can be used for catalog schemas.
Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.