pg sources: subsource health status + snapshot resumption test #18782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sploiselle
force-pushed
the
multi-output-health-refactor
branch
2 times, most recently
from
9cb0775
to
38195bb
Compare
sploiselle
changed the title
Propagating irrecoverable/indefinite errors from the source impl to the health operator was too optimistic about the errors making it all the way to the health status shard. We instead want to propagate errors only once per occurrence from the source reader pipeline and instead handle determining what to do with those values within the health_operator itself. The changes in the health operator make errors more noticeable, while still letting indefinite errors get cleared from being reported. Additionally, when encountering a halting error, we still let all other updates that occurred in parallel to be written; we previously crashed the process too eagerly.
sploiselle
force-pushed
the
multi-output-health-refactor
branch
from
38195bb
to
6e7fc63
Compare
|
@aljoscha @petrosagg I know there was more conversation about this in Slack but as long as we intend to include definite errors in this collection, I believe the demuxing done previously is necessary, and if that sticks around then we should also apply this patch. Let me know if there are additional concerns or anything I can do to help with the review. |
aljoscha
approved these changes
Apr 19, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #18769, we discovered that the cluster test
workflow_pg_snapshot_resumptionwas not working as intended, so I've refactored it to ensure that the source is down (and that the failure was caused by the failpoint).I also needed to refactor how multi-output sources propagate their health statuses to the health operator––there were two issues previously:
In service of the above, I also refactored some of the way
source_reader_pipelinehandles buffering.Motivation
This PR refactors existing code.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.