Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter: Remove the enable_auto_route_introspection_queries LD Flag #18798

Conversation

do-not-use-parker-timmerman
Copy link
Contributor

Motivation

Fixes #18457

This PR removes the ENABLE_AUTO_ROUTE_INTROSPECTION_QUERIES LaunchDarkly flag that was introduced to gate #18310. The original feature shipped with v0.49 and this PR should be included in v0.52, so the feature will have had 3 weeks of bake time.

In addition to removing the LD flag, we also remove the note from our docs that indicates users should set their cluster to mz_introspection. With this feature the documented queries get automatically run on this cluster.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:
    • Queries that only depend on system tables, e.g. the SHOW ... commands, will automatically get run on the mz_introspection cluster, which contain in-memory indexes on these tables to speed up the execution.

Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ld_cleanup: Remove enable_auto_route_introspection_queries Flag
4 participants