Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: Ignore lines that can't be covered #18800

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

def-
Copy link
Contributor

@def- def- commented Apr 17, 2023

See the comment line here for example:
https://buildkite.com/materialize/coverage/builds/22#01878e65-e544-4217-a19e-55fe86c699d4

Motivation

  • This PR fixes a previously unreported bug.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

Copy link
Contributor

@philip-stoev philip-stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He he well we should expect developers to write enough tests to cover the comment lines too! Not a step back on code coverage!

Thanks for the fix, it made sense after a while -- the second comment line was added by the PR while the first was from before the PR in question.

@def- def- merged commit 8147c0b into MaterializeInc:main Apr 18, 2023
@def- def- deleted the pr-coverage-fix branch April 18, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants