adapter: Add test for update_privilege_owners #18804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkosh44
commented
Apr 17, 2023
| }, | ||
| )) | ||
| .collect(); | ||
| Op::UpdateOwner { id, new_owner } => match id { |
There was a problem hiding this comment.
All changes here are removing the update_privilege_owners nested function and whitespace changes.
jkosh44
commented
Apr 17, 2023
| /// Update privileges to reflect the new owner. Based off of PostgreSQL's | ||
| /// implementation: | ||
| /// https://github.com/postgres/postgres/blob/43a33ef54e503b61f269d088f2623ba3b9484ad7/src/backend/utils/adt/acl.c#L1078-L1177 | ||
| fn update_privilege_owners( |
There was a problem hiding this comment.
There are no changes to the contents of this function. It was just extracted from it's old location so I could write a test on it.
5 tasks
maddyblue
approved these changes
Apr 17, 2023
12 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add test.
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.