[persist] Track whether or not our JSON contains a map #18807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If we want to be able to push down casts on
jsonb
columns, it's important that we know when the column is all of a single type. However, currently totally emptyjsonb
objects --{}
-- don't show up in stats at all. This is a minimal change that captures them in stats in a backwards - compatible way.Tips for reviewer
This is not how I'd do things from scratch, but it seems like the smallest change that captures the information we need. I left a TODO to revisit this code when we're cleaning up / getting ready to use this for real.
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-proto
label.