Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update create pg source docs for schemas #18818

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Apr 18, 2023

This commit updates the railroad diagram for the PostgreSQL variant of CREATE SOURCE to include the FOR SCHEMAS syntax. The grammar had already been updated in a previous commit, but the new railroad diagram was never generated.

Motivation

Update docs.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

This commit updates the railroad diagram for the PostgreSQL variant of
`CREATE SOURCE` to include the `FOR SCHEMAS` syntax. The grammar had
already been updated in a previous commit, but the new railroad diagram
was never generated.
@jkosh44 jkosh44 requested a review from sploiselle April 18, 2023 16:10
@jkosh44 jkosh44 requested a review from a team as a code owner April 18, 2023 16:10
Copy link
Contributor

@sploiselle sploiselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, Joe! I thought this was handled as part of the build process these days. my oversight.

@jkosh44 jkosh44 enabled auto-merge (squash) April 18, 2023 17:15
@jkosh44 jkosh44 merged commit d1ef6d7 into MaterializeInc:main Apr 18, 2023
@jkosh44 jkosh44 deleted the create-pg-source-docs branch April 18, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants