Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist: remove CmdMetrics::run_cmd #18825

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

pH14
Copy link
Contributor

@pH14 pH14 commented Apr 18, 2023

Clarifies our metrics usage that cas_mismatch isn't incremented with run_cmd usage. Alternatively, we could just inline these counters to the one use of run_cmd, being init_state

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@pH14 pH14 requested a review from a team as a code owner April 18, 2023 18:45
Copy link
Contributor

@danhhz danhhz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that init_state's treatment of mismatches is unique, inlining it is appealing, but it would certainly be a lot noisier inline. on the balance, I'm definitely okay either way

@pH14 pH14 enabled auto-merge (squash) April 18, 2023 19:29
@pH14 pH14 merged commit debafc8 into MaterializeInc:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants