Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapter: Update catalog schema IDs namespace #18828

Merged
merged 2 commits into from
Apr 18, 2023
Merged

adapter: Update catalog schema IDs namespace #18828

merged 2 commits into from
Apr 18, 2023

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Apr 18, 2023

This commit updates the schema IDs of all catalog schemas so that they are namespaced as system IDs rather than user IDs.

Motivation

This PR fixes a previously unreported bug.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@jkosh44
adapter: Update catalog schema IDs namespace
553775b 
This commit updates the schema IDs of all catalog schemas so that they
are namespaced as system IDs rather than user IDs.
@jkosh44 jkosh44 requested a review from a team as a code owner April 18, 2023 21:40
do-not-use-parker-timmerman
do-not-use-parker-timmerman approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@jkosh44 jkosh44 enabled auto-merge (squash) April 18, 2023 21:42
@jkosh44 jkosh44 merged commit 0ec9557 into MaterializeInc:main Apr 18, 2023
@jkosh44 jkosh44 deleted the system-schema-ids branch April 18, 2023 22:31
@materialize-bot materialize-bot mentioned this pull request Apr 21, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@do-not-use-parker-timmerman do-not-use-parker-timmerman do-not-use-parker-timmerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkosh44 @do-not-use-parker-timmerman