Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci nightly: Remove SLT coverage #18834

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

def-
Copy link
Contributor

@def- def- commented Apr 19, 2023

Not sure if it's used for anything currently. We have PR code coverage now which includes SLT:
https://github.com/MaterializeInc/materialize/blob/main/doc/developer/code-coverage.md

@tokenrove Is that ok for you or do you think we should keep running it?

Motivation

  • This PR refactors existing code.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

Not sure if it's used for anything currently. We have PR code coverage
now which includes SLT:
https://github.com/MaterializeInc/materialize/blob/main/doc/developer/code-coverage.md
@def- def- requested a review from a team as a code owner April 19, 2023 09:13
@def- def- changed the title nightly: Remove SLT coverage ci nightly: Remove SLT coverage Apr 19, 2023
Copy link
Contributor

@tokenrove tokenrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this for now; and great work on PR code coverage!

@def- def- enabled auto-merge April 19, 2023 11:17
@def- def- merged commit 90d66dd into MaterializeInc:main Apr 19, 2023
@def- def- deleted the pr-nightly-coverage-rm branch April 19, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants