Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute: Guarantee that subscribe response data is consolidated #18847

Merged

Conversation

andrewrodriguez-m
Copy link
Contributor

I thought this was guaranteed but couldn't find explicit documentation. Not having to handle unconsolidated data makes processing subscribe responses a little easier.

Motivation

This is already guaranteed here

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@andrewrodriguez-m andrewrodriguez-m marked this pull request as ready for review April 19, 2023 17:40
@andrewrodriguez-m andrewrodriguez-m requested a review from a team April 19, 2023 17:40
Copy link
Contributor

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. I've added a second commit that adds comments to the consolidation sites to point out that we do this now to fulfill a requirement of the compute protocol.

@andrewrodriguez-m andrewrodriguez-m enabled auto-merge (rebase) April 20, 2023 16:42
@andrewrodriguez-m andrewrodriguez-m merged commit 1b5a3b8 into MaterializeInc:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants