Add deserialize derive for the pub struct AppPassword #18867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddyblue
approved these changes
Apr 20, 2023
joacoc
added a commit
to joacoc/materialize
that referenced
this pull request
Apr 21, 2023
…#18867) Adds deserialize derive for the pub struct AppPassword. While it is not a need by the crate itself it is useful for other crates trying to Deserialize an `AppPassword` straight from a network request.
12 tasks
joacoc
added a commit
to joacoc/materialize
that referenced
this pull request
May 1, 2023
…#18867) Adds deserialize derive for the pub struct AppPassword. While it is not a need by the crate itself it is useful for other crates trying to Deserialize an `AppPassword` straight from a network request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding
#[derive(Deserialize)]to the pub structureAppPassword.While it is not a need by the crate itself it is useful for other crates trying to Deserialize an
AppPasswordstraight from a network request.E.g. FronteggClient crate
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.