doc/user: remove mentions to PRIMARY KEY...NOT ENFORCED clause #18870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, thanks! |
sthm
approved these changes
Apr 20, 2023
|
The note for the upsert key is not really actionable, so I'm not sure how helpful it would be. |
joacoc
pushed a commit
to joacoc/materialize
that referenced
this pull request
Apr 21, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was gated to unsafe mode in #15273, but mentions to the clause were left behind in the docs.
Tips for reviewer
I removed mentions to manually setting an upsert key completely, but considered adding the following note:
Since it'd also have to be added under the section about Debezium, I thought a bit harder and maybe it's unnecessary to mention this at all. The signal we have is that users have struggled frequently with inferred keys for sinks, but not for sources. No strong opinion, though.