sql: Allow dropping non-owned descendants #18873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts the changes made in acc39ea. Specifically it allows dropping non-owned objects with a CASCADE statement. This aligns with the behavior in PostgreSQL. Roles are not allowed to directly drop objects if they don't own the object, but they can drop those objects indirectly through CASCADE. The other of acc39ea, who's also the author of this commit, misunderstood the intended behavior. Works towards resolving MaterializeInc#18551 Part of MaterializeInc#11579
|
Another option would be to directly revert acc39ea, but this ends up being much easier. |
maddyblue
approved these changes
Apr 20, 2023
joacoc
pushed a commit
to joacoc/materialize
that referenced
this pull request
Apr 21, 2023
This commit reverts the changes made in acc39ea. Specifically it allows dropping non-owned objects with a CASCADE statement. This aligns with the behavior in PostgreSQL. Roles are not allowed to directly drop objects if they don't own the object, but they can drop those objects indirectly through CASCADE. The author of acc39ea, who's also the author of this commit, misunderstood the intended behavior. Works towards resolving MaterializeInc#18551 Part of MaterializeInc#11579
12 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts the changes made in
acc39ea. Specifically it allows dropping non-owned objects with a CASCADE statement. This aligns with the behavior in PostgreSQL. Roles are not allowed to directly drop objects if they don't own the object, but they can drop those objects indirectly through CASCADE. The other of
acc39ea, who's also the author of this commit, misunderstood the intended behavior.
Works towards resolving #18551
Part of #11579
Motivation
This PR fixes a recognized bug.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.CASCADE.