sql: Correct ownership semantics of indexes #18877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the semantics of index owners in the following ways: - The owner of an index is always set to the owner of the underlying relation. - Only the owner of a relation, or superuser, can create indexes on the relation. - Altering the owner of a relation also alters the owner of any indexes on that relation. This behavior is consistent with PostgreSQL. Works towards resolving MaterializeInc#18551 Part of MaterializeInc#11579
maddyblue
approved these changes
Apr 20, 2023
…ex-owners # Conflicts: # test/sqllogictest/object_ownership.slt
joacoc
pushed a commit
to joacoc/materialize
that referenced
this pull request
Apr 21, 2023
This commit updates the semantics of index owners in the following ways: - The owner of an index is always set to the owner of the underlying relation. - Only the owner of a relation, or superuser, can create indexes on the relation. - Altering the owner of a relation also alters the owner of any indexes on that relation. This behavior is consistent with PostgreSQL. Works towards resolving MaterializeInc#18551 Part of MaterializeInc#11579
12 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the semantics of index owners in the following ways:
This behavior is consistent with PostgreSQL.
Works towards resolving #18551
Part of #11579
Motivation
This PR fixes a recognized bug.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.