Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel-workload test #20354

Merged
merged 18 commits into from
Jul 13, 2023
Merged

parallel-workload test #20354

merged 18 commits into from
Jul 13, 2023

Conversation

def-
Copy link
Contributor

@def- def- commented Jul 5, 2023

Reproduces panics:

bin/parallel-workload-test --threads=100 --seed=173227
thread 'coordinator' panicked at 'cannot fail to peek: CollectionMissing(User(23531))', /home/deen/git/materialize3/src/adapter/src/util.rs:280:23
thread 'coordinator' panicked at 'Dataflow oneshot-select-t1257 requested as_of (Antichain { elements: [1688594212000] }) not >= since (Antichain { elements: [1688594213108] })', src/adapter/src/coord/dataflows.rs:260:13

Before #20267: https://buildkite.com/materialize/nightlies/builds/2738 (failure time 1 min in CI)
After: https://buildkite.com/materialize/nightlies/builds/2739

Still a randomized test, but good enough to make sure this doesn't regress.

Fixes: #20274

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@def- def- force-pushed the pr-parallel_workload branch 5 times, most recently from 089f7f7 to b75da8f Compare July 5, 2023 23:06
@def- def- marked this pull request as ready for review July 5, 2023 23:18
@def- def- requested a review from a team as a code owner July 5, 2023 23:18
@maddyblue
Copy link
Contributor

Woo this is great! I hope to also make a deterministic repro for this specific failure sometime soon. Thanks for covering the random one.

Copy link
Contributor

@philip-stoev philip-stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very impressive! Thank you. I think if we have the following random events:

  • CREATE / DROP VIEW
  • SET ISOLATION_LEVEL - (with 1% probability)
  • [BEGIN] / COMMIT / ROLLBACK (with 10% probability)

We can say that the "concurrent DDL testing" has been taken care of for the foreseeable future.

@def- def- force-pushed the pr-parallel_workload branch 3 times, most recently from c9961c8 to f6561fc Compare July 12, 2023 20:44
@maddyblue
Copy link
Contributor

Do you have thoughts about merging this so it's a nightly, or in some form where we can hit a button in buildkite and it runs on a specific PR?

@def- def- force-pushed the pr-parallel_workload branch 4 times, most recently from 5c27400 to 27813d1 Compare July 12, 2023 22:30
@def-
Copy link
Contributor Author

def- commented Jul 12, 2023

Do you have thoughts about merging this so it's a nightly, or in some form where we can hit a button in buildkite and it runs on a specific PR?

Yes, I now enabled the green subset of this in nightly as part of this change. Should be good to go in and hopefully find regressions. Edit: Green run: https://buildkite.com/materialize/nightlies/builds/2807 & https://buildkite.com/materialize/nightlies/builds/2809

@def- def- marked this pull request as ready for review July 12, 2023 22:31
Copy link
Contributor

@philip-stoev philip-stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the very quick turnaround on this, with immediate installation into Nightly, so exemplary work!

@def- def- enabled auto-merge July 13, 2023 09:26
@def- def- disabled auto-merge July 13, 2023 09:31
@def- def- enabled auto-merge July 13, 2023 09:37
@def- def- merged commit 9664ecd into MaterializeInc:main Jul 13, 2023
67 of 68 checks passed
@def- def- deleted the pr-parallel_workload branch July 13, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Randomized parallel testing with DDLs and transactions
5 participants