-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parallel-workload test #20354
parallel-workload test #20354
Conversation
089f7f7
to
b75da8f
Compare
Woo this is great! I hope to also make a deterministic repro for this specific failure sometime soon. Thanks for covering the random one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is very impressive! Thank you. I think if we have the following random events:
- CREATE / DROP VIEW
- SET ISOLATION_LEVEL - (with 1% probability)
- [BEGIN] / COMMIT / ROLLBACK (with 10% probability)
We can say that the "concurrent DDL testing" has been taken care of for the foreseeable future.
c9961c8
to
f6561fc
Compare
Do you have thoughts about merging this so it's a nightly, or in some form where we can hit a button in buildkite and it runs on a specific PR? |
5c27400
to
27813d1
Compare
Yes, I now enabled the green subset of this in nightly as part of this change. Should be good to go in and hopefully find regressions. Edit: Green run: https://buildkite.com/materialize/nightlies/builds/2807 & https://buildkite.com/materialize/nightlies/builds/2809 |
27813d1
to
76a4655
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the very quick turnaround on this, with immediate installation into Nightly, so exemplary work!
f9fd455
to
6ccb768
Compare
6ccb768
to
c39560e
Compare
Reproduces panics:
Before #20267: https://buildkite.com/materialize/nightlies/builds/2738 (failure time 1 min in CI)
After: https://buildkite.com/materialize/nightlies/builds/2739
Still a randomized test, but good enough to make sure this doesn't regress.
Fixes: #20274
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.