Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash when explaining a Get without a Let #2421

Merged
merged 1 commit into from Mar 25, 2020
Merged

Don't crash when explaining a Get without a Let #2421

merged 1 commit into from Mar 25, 2020

Conversation

jamii
Copy link
Contributor

@jamii jamii commented Mar 25, 2020 •
edited

Hopefully fixes #2413

@jamii
Copy link
Contributor Author

jamii commented Mar 25, 2020

@frankmcsherry Can you try to repro with this patch?

@frankmcsherry frankmcsherry self-requested a review March 25, 2020 20:30
frankmcsherry
frankmcsherry approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We concluded that this is surely correct! (and that it fixes a very clear source of broken-ness).

@jamii jamii merged commit fd07dce into MaterializeInc:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankmcsherry frankmcsherry frankmcsherry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fn explain panics on missing keys
2 participants
@jamii @frankmcsherry