Increasing batch size in ingest mode #3822
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @frankmcsherry, this PR reduces the frequency at which we downgrade capabilities (thus creating larger batch sizes) when we detect that we are trailing behind a source (when the number of known messages in the topic is greater than the number of processed messages by X).
I wanted to get this PR up before leaving but I have not verified that it actually improves performance.
This change is