aws_util: Prepare for supporting S3 as well #5319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow it to be shared between different services in later commits.
This is a more common idiom.
Before this credentials weren't fetched until we tried to use the client, causing credentials errors to show up well after the dataflow had been created. With this we can fail to create the source at all.
JLDLaughlin
approved these changes
Jan 14, 2021
| pub access_key_id: Option<String>, | ||
| pub secret_access_key: Option<String>, | ||
| pub token: Option<String>, | ||
| pub aws_info: AwsConnectInfo, |
| @@ -44,6 +46,7 @@ pub async fn client( | |||
| info!("AWS access_key_id and secret_access_key not provided, creating a new Kinesis client using a chain provider."); | |||
| let mut provider = ChainProvider::new(); | |||
| provider.set_timeout(Duration::from_secs(10)); | |||
| provider.credentials().await?; // ensure that credentials exist | |||
src/aws-util/src/kinesis.rs
Outdated
| /// | ||
| /// The AutoRefreshingProvider caches the underlying provider's AWS credentials, | ||
| /// If statically provided connection information information is not provided, |
There was a problem hiding this comment.
Maybe: If static connection information is not provided, ...
quodlibetor
force-pushed
the
aws-util-unification
branch
from
822e365
to
7a4277d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of small changes to aws_util that was split out of #5194 / #5202 , which contain further changes to these files.
This change is