Support lists, arrays, and maps in sinks #7080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #6645 |
|
Tests are failing due to #7081 , but this is RFAL |
aljoscha
approved these changes
Jun 17, 2021
| $ kafka-verify format=avro sink=materialize.public.map_sink sort-messages=true | ||
| {"before": null, "after": {"row": {"map": {"a": {"int": 1}, "b": {"int": 2}}}}} | ||
|
|
||
| > CREATE VIEW list_data (list) AS SELECT LIST[1, 2]; |
There was a problem hiding this comment.
nit: for completeness we could add a test for ARRAY as well, but we discourage their use so it's probably ok.
There was a problem hiding this comment.
yeah, I decided not to test for it since it's highly discouraged and therefore IMO not really part of the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is the actual work. The second commit is to make it possible to write .td tests involving Avro maps.