Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Add "Node.js and Materialize" guide #7543

Merged
merged 6 commits into from
Jul 27, 2021

Conversation

ruf-io
Copy link
Contributor

@ruf-io ruf-io commented Jul 26, 2021

This guide centralizes and links out to all the reference content necessary for using Node.js with Materialize.

Why: Help developers who are building Node.js applications that interact with Materialize understand how to communicate with Materialize, which concepts (like TAIL and FETCH) to investigate further, and give them some barebones examples to get up and running with a Node.js app and Materialize.

Where more detail may be necessary:

  1. @petrosagg has a more advanced Node.js sample app that uses pg-cursor and the node.js streams API, but I left this out of the guide because it felt like too much of a leap in complexity from the basic examples provided throughout the rest of the guide. I think we can create either a demo page or a separate article walking through Petros' example.
  2. I commented out a streams example using pg-query-stream because it won't be ready until Petros' PR to the external repo is merged: pg-query-stream: make rows available as soon as possible brianc/node-postgres#2573

@ruf-io ruf-io added the A-docs Area: documentation label Jul 26, 2021
@ruf-io ruf-io requested a review from msudberg July 26, 2021 18:21
Copy link
Contributor

@petrosagg petrosagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/user/content/guides/node-js.md Outdated Show resolved Hide resolved
doc/user/content/guides/node-js.md Outdated Show resolved Hide resolved
doc/user/content/guides/node-js.md Outdated Show resolved Hide resolved
doc/user/content/guides/node-js.md Outdated Show resolved Hide resolved
@ruf-io ruf-io merged commit 1907a56 into MaterializeInc:main Jul 27, 2021
Copy link
Contributor

@msudberg msudberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Andy --

This looks really good! My suggestions are mostly focused on moving information to an introduction before the code instead of interspersing it or putting it below.

doc/user/content/guides/node-js.md Show resolved Hide resolved
doc/user/content/guides/node-js.md Show resolved Hide resolved
doc/user/content/guides/node-js.md Show resolved Hide resolved
doc/user/content/guides/node-js.md Show resolved Hide resolved
doc/user/content/guides/node-js.md Show resolved Hide resolved
doc/user/content/guides/node-js.md Show resolved Hide resolved
doc/user/content/guides/node-js.md Show resolved Hide resolved
doc/user/content/guides/node-js.md Show resolved Hide resolved
doc/user/content/guides/node-js.md Show resolved Hide resolved
doc/user/content/guides/node-js.md Show resolved Hide resolved
@ruf-io
Copy link
Contributor Author

ruf-io commented Jul 28, 2021

@msudberg I merged after getting a thumbs-up from Petros, but will integrate your feedback into an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants