coord: check while dropping error'd sink connector #7563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
approved these changes
Jul 28, 2021
| self.catalog_transact(vec![catalog::Op::DropItem(id)]) | ||
| .await | ||
| .expect("deleting placeholder sink cannot fail"); | ||
| // Drop the placeholder sink if still present. |
There was a problem hiding this comment.
I think it'd be nice to make this look a bit like the else branch above and say something like "Another session may have dropped the placeholder sink while we were attempting to create the connector, in which case we don't need to do anything."
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7548