Temporal tidy-up #7624
Merged
Temporal tidy-up #7624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sploiselle
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
ty for cleaning this up; this structure is really clear to me what the intended invariants are.
🤦 I did notice that I also left a dangling reference to upper_bound_u64 in a comment (wish Rename Symbol was smart enough to catch these, too, but alas).
// ensures that
upper_bound_u64will be at leasttime, which
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of dusting on @sploiselle's decimal stuff. Mostly me trying to minimize incidental complexity because things are already super complicated. I fixed one issue where negative upper bounds would be ignored, but I probably introduced a few issues too. Excited to see how testing looks on it.
@sploiselle if you get a chance to look great, but I'll land even if you're off so no sweat if busy.