Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist: start replacing CmdResponse with Future #7630

Merged
merged 1 commit into from
Aug 4, 2021

Commits on Aug 4, 2021

  1. persist: start replacing CmdResponse with Future

    The original idea behind CmdResponse (plumbing a channel all the way
    from persist to pgwire) hasn't ended up working out. It turns out that
    callers of write and seal just want a std::future::Future, so give them
    one.
    
    The persist Future is powered by a oneshot::channel(), but hide this
    implementation detail. Bonus: This much more elegantly handles channel
    errors than what we had before.
    danhhz committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    327ffc4 View commit details
    Browse the repository at this point in the history