Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform: remove dead code #7681

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Conversation

petrosagg
Copy link
Contributor

@benesch @wangandi I put you as reviewers based on git blame. These files are not included in any cargo target as far as I can tell

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@benesch benesch requested review from frankmcsherry and removed request for benesch August 4, 2021 14:15
@benesch
Copy link
Member

benesch commented Aug 4, 2021

Replacing myself with @frankmcsherry because I don't know what's desired here!

@frankmcsherry
Copy link
Contributor

I suspect these are probably fine to delete. They represent work that was eventually done a different way, but without the conviction that we should remove the alternative approaches. I think aggregation.rs was mine (and was about reshaping Reduce in a way that we have issues filed for). I think use_indexes.rs was @wangandi and was about using indexes for indexed access to data (which we have in MZ now).

@petrosagg petrosagg merged commit 11c2298 into MaterializeInc:main Aug 4, 2021
@petrosagg petrosagg deleted the dead-code branch November 24, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants