Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: reduce all "deny" and "forbid" lints to "warn" #7692

Merged
merged 1 commit into from
Aug 4, 2021

Commits on Aug 4, 2021

  1. *: reduce all "deny" and "forbid" lints to "warn"

    Lints at the deny/forbid level can be very frustrating when developing,
    because you're forced to comply with the lint even when you're still
    prototyping, just to get your code to compile.
    
    This commit downgrades all these lints to "warn", to optimize for the
    development experience. In CI, these lints are still enforced at the
    "deny" level by our Clippy configuration, which upgrades all warnings to
    hard errors.
    
    The one glitch here is that `forbid` used to prevent submodules from
    re-enabling the forbidden lint. I propose that we solve this socially,
    by making it taboo to add `#![allow(missing_docs)]` unless you've gotten
    buy-in from the overall owner of that area of the codebase.
    benesch committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    31af7bd View commit details
    Browse the repository at this point in the history