Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform: Minimize the number of non-leaves in join equivalence expressions. #7895

Merged
merged 6 commits into from Sep 8, 2021
Merged

Transform: Minimize the number of non-leaves in join equivalence expressions. #7895

merged 6 commits into from Sep 8, 2021

Commits on Sep 1, 2021

  1. Minimize the number of leaves in join equivalence expressions.

    Andi Wang committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    f9aa67d View commit details
    Browse the repository at this point in the history

  2. Test changes.

    Andi Wang committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    cd47b5a View commit details
    Browse the repository at this point in the history

  3. Count non-leaves instead of leaves. 

    This allows distinguishing between the complexity of
CallUnary{CallUnary{Column}} and CallUnary{Column}.

Constants are considered to be less complex that any other type of
MirScalarExpr.
    Andi Wang committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    056b44f View commit details
    Browse the repository at this point in the history

  4. Add comments.

    Andi Wang committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    6a83a23 View commit details
    Browse the repository at this point in the history

  5. Write down the rules for a valid complexity ranking.

    Andi Wang committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    040338f View commit details
    Browse the repository at this point in the history

  6. Do not count literal nodes in the complexity ranking.

    Andi Wang committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    9ebc436 View commit details
    Browse the repository at this point in the history