Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing optional fields are not returned as null when requested with response_fields #516

Closed
ml-evs opened this issue Sep 23, 2020 · 0 comments · Fixed by #797
Closed

Missing optional fields are not returned as null when requested with response_fields #516

ml-evs opened this issue Sep 23, 2020 · 0 comments · Fixed by #797
Assignees
@ml-evs
Labels
OPTIMADE v1.0 A label for tagging issues/PRs that are required for compliance with v1.0 of the OPTIMADE spec priority/medium Issue or PR with a consensus of medium priority server Issues pertaining to the example server implementation

Comments

@ml-evs
Copy link
Member

ml-evs commented Sep 23, 2020 •
edited

According to the specification, if an optional field is asked for using the response_fields query parameter, it must be returned as null if missing from the document. We currently don't do this (see e.g. immutable_id in the test server).

This is also related to the problem of returning errors when unknown fields are requested (PR: #504 Issue: #263)
@ml-evs ml-evs added the server Issues pertaining to the example server implementation label Sep 23, 2020
@ml-evs ml-evs self-assigned this Sep 23, 2020
@ml-evs ml-evs mentioned this issue Sep 23, 2020
Merged
1 task
@ml-evs ml-evs added OPTIMADE v1.0 A label for tagging issues/PRs that are required for compliance with v1.0 of the OPTIMADE spec priority/medium Issue or PR with a consensus of medium priority labels Dec 14, 2020
@ml-evs ml-evs mentioned this issue May 18, 2021
Merged
5 tasks
ml-evs added a commit that referenced this issue May 18, 2021
@ml-evs
Handle provider-specific and unknown response_fields (closes #516)
8115ae7
ml-evs added a commit that referenced this issue May 27, 2021
@ml-evs
Handle provider-specific and unknown response_fields (closes #516)
d68086b
ml-evs added a commit that referenced this issue May 31, 2021
@ml-evs
Handle provider-specific and unknown response_fields (closes #516)
2a03258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
OPTIMADE v1.0 A label for tagging issues/PRs that are required for compliance with v1.0 of the OPTIMADE spec priority/medium Issue or PR with a consensus of medium priority server Issues pertaining to the example server implementation
Projects
None yet
Milestone
No milestone
1 participant
@ml-evs