Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responses for unknown fields #504

Closed
wants to merge 2 commits into from
Closed

Responses for unknown fields #504

wants to merge 2 commits into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 18, 2020

Eventually closes #263.

  • Parse filters for unknown properties, dropping those that are from other providers and raising errors for those that are entirely unknown
    • Find better way of passing field list to FilterTransformer, probably via Mapper which should save the schema too
  • Handle unknown response as a 400 Bad Request
  • Validate unknown field responses

@ml-evs ml-evs added enhancement New feature or request server Issues pertaining to the example server implementation transformer/MongoDB Related to filter transformer for MongoDB validator Related to the OPTIMADE validator labels Sep 18, 2020
This was referenced Sep 21, 2020
Merged
Closed
Merged
Closed
@ml-evs ml-evs added the blocking For issues/PRs that are blocking other PRs. label Sep 23, 2020
@ml-evs ml-evs mentioned this pull request Oct 19, 2020
Merged
5 tasks
ml-evs added a commit that referenced this pull request Oct 27, 2020
@ml-evs
Use response fields in validation:
a70b0d2 
- when getting a "chosen entry"
- when making a request of SHOULD/OPTIONAL fields of entry endpoints
- improved error handling of chosen_entry and empty endpoints
- Until None valued response fields are applied based on the
entry schema and the response fields query parameter, return
all unset fields with exclude_unset=False when handling response
fields (should be dealt with in #504)
ml-evs added a commit that referenced this pull request Oct 27, 2020
@ml-evs
Use response fields in validation (closes #514)
9681f86 
- when getting a "chosen entry"
- when making a request of SHOULD/OPTIONAL fields of entry endpoints
- improved error handling of chosen_entry and empty endpoints
- Until None valued response fields are applied based on the
entry schema and the response fields query parameter, return
all unset fields with exclude_unset=False when handling response
fields (should be dealt with in #504)
ml-evs added a commit that referenced this pull request Oct 27, 2020
@ml-evs
Use response fields in validation (closes #514)
6f34399 
- when getting a "chosen entry"
- when making a request of SHOULD/OPTIONAL fields of entry endpoints
- improved error handling of chosen_entry and empty endpoints
- Until None valued response fields are applied based on the
entry schema and the response fields query parameter, return
all unset fields with exclude_unset=False when handling response
fields (should be dealt with in #504)
@ml-evs ml-evs removed the blocking For issues/PRs that are blocking other PRs. label Oct 28, 2020
@ml-evs ml-evs mentioned this pull request Oct 30, 2020
Merged
@ml-evs ml-evs mentioned this pull request Nov 7, 2020
Merged
4 tasks
@ml-evs ml-evs added the blocked For issues/PRs that are blocked by required changes/clarifications to the specification. label Nov 24, 2020
@ml-evs ml-evs added OPTIMADE v1.0 A label for tagging issues/PRs that are required for compliance with v1.0 of the OPTIMADE spec and removed blocked For issues/PRs that are blocked by required changes/clarifications to the specification. labels Dec 14, 2020
@ml-evs ml-evs mentioned this pull request May 17, 2021
Merged
5 tasks
@ml-evs
Copy link
Member Author

ml-evs commented May 18, 2021

Superseded by #797

@ml-evs ml-evs closed this May 18, 2021
@ml-evs ml-evs deleted the ml-evs/unknown_field_responses branch May 18, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA Awaiting requested review from CasperWA CasperWA will be requested when the pull request is marked ready for review CasperWA is a code owner

@JPBergsma JPBergsma Awaiting requested review from JPBergsma JPBergsma will be requested when the pull request is marked ready for review JPBergsma is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request OPTIMADE v1.0 A label for tagging issues/PRs that are required for compliance with v1.0 of the OPTIMADE spec server Issues pertaining to the example server implementation transformer/MongoDB Related to filter transformer for MongoDB validator Related to the OPTIMADE validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect responses for unknown properties
1 participant
@ml-evs