Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 support (from v0.15+) #749

Closed
CasperWA opened this issue Mar 23, 2021 · 7 comments
Closed

Drop Python 3.6 support (from v0.15+) #749

CasperWA opened this issue Mar 23, 2021 · 7 comments
Labels
dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build needs discussion priority/low Issue or PR with a consensus of low priority question Further information is requested suggestions

Comments

@CasperWA
Copy link
Member

CasperWA commented Mar 23, 2021

It seems about time Python 3.6 support is dropped.

Some points:

  • We can't use deferred type hints with Python 3.6.
  • numpy and pymatgen have dropped Python 3.6 support.
@CasperWA CasperWA added question Further information is requested dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build priority/low Issue or PR with a consensus of low priority suggestions needs discussion labels Mar 23, 2021
@ml-evs
Copy link
Member

ml-evs commented Mar 23, 2021

This should also simplify much of our dependency handling for e.g. pymatgen and numpy

@ml-evs
Copy link
Member

ml-evs commented Mar 23, 2021

Any objection to dropping it before v0.14.0?

@CasperWA
Copy link
Member Author

Any objection to dropping it before v0.14.0?

Not really. But I think we should list all considerations in the OP first, before dropping support.
It might be nice with a grace period as well (although I understand your POV considering #748).

@ml-evs
Copy link
Member

ml-evs commented Mar 23, 2021

I have made #750 to actually do this when we are ready.

I honestly don't see any downsides at the moment. I don't think we want to support another whole minor version cycle (v0.14.x) with Python 3.6 so now seems like a sensible time to drop it. Also before the project gets advertised more widely...

@CasperWA
Copy link
Member Author

Any comments on this @markus1978 or @shyamd?

@shyamd
Copy link
Contributor

shyamd commented Mar 23, 2021

We've dropped it in MP stuff. Numpy no longer supports 3.6, so it's hard to keep supporting it.

@CasperWA CasperWA changed the title Drop Python 3.6 support Drop Python 3.6 support (from v0.15+) Mar 25, 2021
@CasperWA
Copy link
Member Author

So on Slack we've discussed a bit and agreed to have a small grace period, since the immediate issue has been resolved and it is not crucial anymore to drop Python 3.6 support. While this package is maybe not widely used (especially in production) yet, the grace period might be a bit grand - but it's good practice, and it seems better to give notice before dropping it. Even if it's just a single user that is hit.

ml-evs added a commit that referenced this issue Jun 1, 2021
- Remove Python 3.6 deprecation warning

- Remove SQLAlchemy fix for Python 3.6 aiida-core
ml-evs added a commit that referenced this issue Jun 1, 2021
- Remove Python 3.6 deprecation warning

Co-authored-by: Casper Welzel Andersen <CasperWA@users.noreply.github.com>
ml-evs added a commit that referenced this issue Jun 1, 2021
- Remove Python 3.6 deprecation warning

Co-authored-by: Casper Welzel Andersen <CasperWA@users.noreply.github.com>
@ml-evs ml-evs closed this as completed in afa4efe Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build needs discussion priority/low Issue or PR with a consensus of low priority question Further information is requested suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants