Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run full API docs invoke task for every PR #748

Merged
merged 2 commits into from Mar 23, 2021
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Mar 23, 2021

Closes #747.

It looks like the Elasticsearch docs will need to be fixed as part of this PR as it uses a deferred type hint. This may require switching to Python 3.9 for docs builds.

@ml-evs ml-evs requested a review from CasperWA as a code owner March 23, 2021 16:56
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #748 (46c9a8f) into master (4f503eb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #748   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files          68       68           
  Lines        3663     3663           
=======================================
  Hits         3399     3399           
  Misses        264      264           
Flag Coverage Δ
project 92.79% <ø> (ø)
validator 92.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/entry_collections/elasticsearch.py 97.91% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f503eb...46c9a8f. Read the comment docs.

@ml-evs ml-evs requested a review from markus1978 as a code owner March 23, 2021 17:04
@ml-evs ml-evs force-pushed the ml-evs/close_#747 branch 2 times, most recently from 489ee77 to f1a31a5 Compare March 23, 2021 17:11
@ml-evs
Copy link
Member Author

ml-evs commented Mar 23, 2021

Hmmm, so we can't use deferred type hints with Python 3.6. Is it time to drop Python 3.6 support, or is it not worth it for the sake of an optional type hint?

@CasperWA
Copy link
Member

Hmmm, so we can't use deferred type hints with Python 3.6. Is it time to drop Python 3.6 support, or is it not worth it for the sake of an optional type hint?

I think we should definitely start considering dropping Python 3.6 support.

@CasperWA
Copy link
Member

Fixed it - no reason to look to the future 😅

@ml-evs
Copy link
Member Author

ml-evs commented Mar 23, 2021

Fixed it - no reason to look to the future sweat_smile

Ah, did you test this locally with mkdocs too? I was under the impression it wasn't supported

@CasperWA
Copy link
Member

Ah, did you test this locally with mkdocs too? I was under the impression it wasn't supported

Yup. And it looks all right in the produced documentation as well :)

@ml-evs
Copy link
Member Author

ml-evs commented Mar 23, 2021

Nice, let's punch it then

CasperWA
CasperWA previously approved these changes Mar 23, 2021
ml-evs and others added 2 commits March 23, 2021 19:09
@CasperWA
Copy link
Member

It's a rebase+merge (or similar) from here on, I think.

@CasperWA CasperWA merged commit 46c9a8f into master Mar 23, 2021
@CasperWA CasperWA deleted the ml-evs/close_#747 branch March 23, 2021 18:19
@CasperWA CasperWA temporarily deployed to optimade March 23, 2021 18:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs builds are not properly tested for each PR
2 participants