New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run full API docs invoke task for every PR #748
Conversation
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 68 68
Lines 3663 3663
=======================================
Hits 3399 3399
Misses 264 264
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
489ee77
to
f1a31a5
Compare
Hmmm, so we can't use deferred type hints with Python 3.6. Is it time to drop Python 3.6 support, or is it not worth it for the sake of an optional type hint? |
I think we should definitely start considering dropping Python 3.6 support. |
41a30a0
to
88de5a9
Compare
Fixed it - no reason to look to the future 😅 |
Ah, did you test this locally with mkdocs too? I was under the impression it wasn't supported |
Yup. And it looks all right in the produced documentation as well :) |
Nice, let's punch it then |
Co-authored-by: Casper Welzel Andersen <casper.andersen@epfl.ch>
33d4fec
to
46c9a8f
Compare
It's a rebase+merge (or similar) from here on, I think. |
Closes #747.
It looks like the Elasticsearch docs will need to be fixed as part of this PR as it uses a deferred type hint. This may require switching to Python 3.9 for docs builds.