Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code check fails because there is no valid version of jsmin #938

Closed
JPBergsma opened this issue Sep 6, 2021 · 3 comments · Fixed by #941
Closed

Code check fails because there is no valid version of jsmin #938

JPBergsma opened this issue Sep 6, 2021 · 3 comments · Fixed by #941
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) docs Issues pertaining to documentation. priority/high Issue or PR with a consensus of high priority

Comments

@JPBergsma
Copy link
Contributor

When I created PR#937 the test fails with the error message:
ERROR: No matching distribution found for jsmin>=2.2.2

ERROR: Command errored out with exit status 1:
command: /opt/hostedtoolcache/Python/3.8.11/x64/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-wj_6aaxj/jsmin_3373d4e1cba348b681a19efd274ceeb4/setup.py'"'"'; file='"'"'/tmp/pip-install-wj_6aaxj/jsmin_3373d4e1cba348b681a19efd274ceeb4/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(file) if os.path.exists(file) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-bczs0nja
cwd: /tmp/pip-install-wj_6aaxj/jsmin_3373d4e1cba348b681a19efd274ceeb4/
Complete output (1 lines):
error in jsmin setup command: use_2to3 is invalid.

@ml-evs
Copy link
Member

ml-evs commented Sep 7, 2021

I think the first one is a misleading error as jsmin 2.2.2 definitely exists (https://pypi.org/project/jsmin/).

Let's run a dependabot check to see if this has already been fixed upstream, and if not, we can try pinning the version in your PR.

@ml-evs ml-evs added CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) docs Issues pertaining to documentation. priority/high Issue or PR with a consensus of high priority labels Sep 7, 2021
@JPBergsma
Copy link
Contributor Author

See also this issue tikitu/jsmin#33

@ml-evs
Copy link
Member

ml-evs commented Sep 7, 2021

Let's just follow everyone else in that thread and remove the mkdocs minify plugin, we don't need it and it hasn't been updated in a while.

@JPBergsma JPBergsma changed the title Code check fails because ther is no valid version of jsmin Code check fails because there is no valid version of jsmin Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) docs Issues pertaining to documentation. priority/high Issue or PR with a consensus of high priority
Projects
None yet
2 participants