Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the dependency on mkdocs-minify because of issue #938. #941

Merged
merged 1 commit into from Sep 7, 2021

Conversation

JPBergsma
Copy link
Contributor

@JPBergsma JPBergsma commented Sep 7, 2021

I removed the references to minify because of Matthews remark in #938

Closes #938.

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #941 (b7becc7) into master (11477de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #941   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          67       67           
  Lines        3786     3786           
=======================================
  Hits         3513     3513           
  Misses        273      273           
Flag Coverage Δ
project 92.78% <ø> (ø)
validator 92.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11477de...b7becc7. Read the comment docs.

@JPBergsma JPBergsma marked this pull request as ready for review September 7, 2021 15:35
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this @JPBergsma!

@ml-evs ml-evs merged commit 7d898af into master Sep 7, 2021
@ml-evs ml-evs deleted the JPBergsma/remove_minify branch September 7, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code check fails because there is no valid version of jsmin
2 participants