Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize package #113

Merged
merged 3 commits into from Jan 6, 2020
Merged

Reorganize package #113

merged 3 commits into from Jan 6, 2020

Conversation

CasperWA
Copy link
Member

Closes #72

I also tried to move validator out into the root dir, but it proved difficult to run tests then, so I reverted it.

- Move tests out to root dir: "tests"
- Move images into root dir: "images"
- Renamse dir "tests" to "data" under "server", keeping only the JSON
files
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #113 into master will decrease coverage by 3.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   86.16%   82.97%   -3.19%     
==========================================
  Files          47       39       -8     
  Lines        2508     1780     -728     
==========================================
- Hits         2161     1477     -684     
+ Misses        347      303      -44
Flag Coverage Δ
#unittests 82.97% <0%> (-3.19%) ⬇️
Impacted Files Coverage Δ
optimade/server/main_index.py 91.66% <0%> (ø) ⬆️
optimade/server/main.py 93.75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf11f5...5e0dba2. Read the comment docs.

@ltalirz ltalirz self-requested a review January 6, 2020 14:53
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@ltalirz ltalirz merged commit 5a23f2e into master Jan 6, 2020
@CasperWA CasperWA deleted the reorganize_package branch January 7, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package structure
2 participants