New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted check_response so it can also handle single entries. #1130
Adjusted check_response so it can also handle single entries. #1130
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1130 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 68 68
Lines 3889 3889
=======================================
Hits 3593 3593
Misses 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested below.
Do you plan on using this functionality somewhere? I see the other fixtures in the query params conftest.py
(like checking for required response fields) will also only work for the multi-entry endpoints. Should they be updated too?
I tried to use a test like this to find out what was going wrong with the single entry endpoint for the trajectories. |
@ml-evs I have processed your comments. |
Sorry @JPBergsma, this one got lost. If you think it is useful we can merge it; I'll rebase -> accept -> merge now if all the tests still pass. |
Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
c4c8721
to
8a06903
Compare
In #1125 I noticed that the
check_response
function did not work for single entry endpoints.This code should fix that issue.
closes #1125