Add support for number-based pagination #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
=======================================
Coverage 92.41% 92.42%
=======================================
Files 68 68
Lines 3904 3909 +5
=======================================
+ Hits 3608 3613 +5
Misses 296 296
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ml-evs
reviewed
May 2, 2022
ml-evs
changed the title
ml-evs
requested changes
May 6, 2022
|
Just rebasing this PR to see how it interacts with #1141 |
ml-evs
force-pushed
the
JPBergsma/add_support_page_number
branch
from
8fa1597
to
37cdf26
Compare
|
Lots of GitHub actions failures this morning, will try again later. |
ml-evs
added
enhancement
ml-evs
reviewed
May 9, 2022
ml-evs
force-pushed
the
JPBergsma/add_support_page_number
branch
2 times, most recently
from
21ab8af
to
ccaa99d
Compare
…in the case of paging so ids of documents that are not returned on this page do not have to be specified.
…hen the sorting takes place on a field other than id.
Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
…rs are supplied. Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
…arameters are set.
- If a single ID is passed as a string, validate the request as a single entry request - If a single ID is passed within a list, validate it is a multi-entry request that only returns one result
ml-evs
force-pushed
the
JPBergsma/add_support_page_number
branch
from
ccaa99d
to
d53cc06
Compare
ml-evs
approved these changes
May 10, 2022
There was a problem hiding this comment.
This LGTM now @JPBergsma, I will merge once the tests pass, then release 0.17!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have added support for the
page_numberquery parameter, as already mentioned in #1132.I have also added a test for this.
I had not realized that I also had to add the IDs that are not in the response but do meet the requirements of the filter.
I therefore adjusted the 'check_response' function, so this is no longer necessary.
This also required changing another test.
Finally, I now also sort the response IDs as the sort in python could be done differently than the sort in the query.