Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect meta->data_returned for paginated results with MongoDB #1141

Merged
merged 2 commits into from May 8, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 6, 2022

Closes #1140.

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1141 (5b62eda) into master (5db4452) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1141   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          68       68           
  Lines        3888     3889    +1     
=======================================
+ Hits         3592     3593    +1     
  Misses        296      296           
Flag Coverage Δ
project 92.38% <100.00%> (+<0.01%) ⬆️
validator 92.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/entry_collections/mongo.py 94.54% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db4452...5b62eda. Read the comment docs.

@ml-evs ml-evs force-pushed the ml-evs/fix_data_returned branch from df277b8 to 49342aa Compare May 6, 2022 10:38
@ml-evs ml-evs force-pushed the ml-evs/fix_data_returned branch from 49342aa to 675486a Compare May 8, 2022 10:21
@ml-evs
Copy link
Member Author

ml-evs commented May 8, 2022

Had to add a few tricks to get the immutable_id stuff working, so actually going to split this into 2 PRs.

@ml-evs ml-evs force-pushed the ml-evs/fix_data_returned branch from 576ebbf to b38dab7 Compare May 8, 2022 11:13
@ml-evs ml-evs added bug Something isn't working priority/high Issue or PR with a consensus of high priority server Issues pertaining to the example server implementation labels May 8, 2022
@ml-evs
Copy link
Member Author

ml-evs commented May 8, 2022

The remaining changes now are pretty trivial (and already reviewed once by @JPBergsma) so I will self-merge when tests pass.

@ml-evs
Copy link
Member Author

ml-evs commented May 8, 2022

Annoyingly all the tests are failing due to an under-pinned dependency in aiida-core (namely, upf-to-json). I hate that we have to rely on AiiDA and verdi setup (due to its complexity) etc. working in our CI...

@ml-evs
Copy link
Member Author

ml-evs commented May 8, 2022

AiiDA pins to upf-to-json~=0.9.2 and tests upf-to-json==0.9.3 in its CI. upf-to-json==0.9.4 just came out and seems to break things, so I have pinned back to 0.9.2. We are already pinned to an older AiiDA version (1.6, not 2) so doubt this will be backported.

@ml-evs ml-evs force-pushed the ml-evs/fix_data_returned branch 2 times, most recently from acedc56 to 32ccf00 Compare May 8, 2022 13:51
@ml-evs ml-evs force-pushed the ml-evs/fix_data_returned branch from 32ccf00 to 5b62eda Compare May 8, 2022 14:06
@ml-evs ml-evs merged commit 6133cf1 into master May 8, 2022
@ml-evs ml-evs deleted the ml-evs/fix_data_returned branch May 8, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/high Issue or PR with a consensus of high priority server Issues pertaining to the example server implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meta->data_returned is incorrect for paginated results with MongoDB
2 participants