Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenAPI tags #121

Merged
merged 1 commit into from Jan 8, 2020
Merged

Update OpenAPI tags #121

merged 1 commit into from Jan 8, 2020

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Jan 8, 2020

Fixes #120

Remove entry endpoints from all /info endpoints.
Make all tags plural.

Remove entry endpoints from all `/info` endpoints.
Make all tags plural.
@CasperWA CasperWA added the OpenAPI OpenAPI / Swagger related issue label Jan 8, 2020
@CasperWA CasperWA requested a review from ltalirz January 8, 2020 10:24
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   82.81%   82.81%           
=======================================
  Files          39       39           
  Lines        1810     1810           
=======================================
  Hits         1499     1499           
  Misses        311      311
Flag Coverage Δ
#unittests 82.81% <ø> (ø) ⬆️
Impacted Files Coverage Δ
optimade/server/routers/references.py 100% <ø> (ø) ⬆️
optimade/server/routers/info.py 95.83% <ø> (ø) ⬆️
optimade/server/routers/structures.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a252260...52d4941. Read the comment docs.

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @CasperWA , I agree that this reduces confusion

@CasperWA CasperWA merged commit e991b31 into master Jan 8, 2020
@CasperWA CasperWA deleted the fix_120_clean_autodoc_swagger branch January 8, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenAPI OpenAPI / Swagger related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

info endpoint duplicated?
2 participants