Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to pydantic v1 #28

Merged
merged 6 commits into from
Jan 9, 2020
Merged

Update to pydantic v1 #28

merged 6 commits into from
Jan 9, 2020

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Jan 8, 2020

Fixes #27

This will update this package to 0.3.1.

Fixes relevant for pydantic v1.

Minor fixes include:

  • Adapting pytest.ini to not show irrelevant warnings.
  • Implementing the same as was done for Update OpenAPI tags Materials-Consortia/optimade-python-tools#121, i.e., fix OpenAPI headlines by fixing endpoint tags in the routers.
  • Update the mappers. Specifically introduce TOP_LEVEL_NON_ATTRIBUTES_FIELDS and remove irrelevant code from the structure mapper.
  • Remove a few pylint disable comments.

@CasperWA
Fix pytest.ini
b3d2d5b
@CasperWA
Up to version 0.3.1, set pydantic to v1.x
33f4d9c
@CasperWA
Clean up OpenAPI tags for endpoints
a88f3fc
@CasperWA
Mapper update
997b7a8 
Use TOP_LEVEL_NON_ATTRIBUTES_FIELDS to define all non-`attributes`
fields in an entry.

Remove irrelevant code from structures mapper.
@CasperWA
Change *skip_defaults -> *exclude_unset
2d59444
@CasperWA
Fix pagination
837ddc3 
pydantic's `AnyUrl` does not support a `?` at the end of a URL.
@CasperWA CasperWA merged commit ec0889b into aiidateam:develop Jan 9, 2020
@CasperWA CasperWA deleted the update_pydantic_v1 branch January 9, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to pydantic v1
1 participant
@CasperWA