New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix load_from_json
#137
Fix load_from_json
#137
Conversation
Add test for config.py, for now only with a simple test to run load_from_json().
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
=======================================
Coverage 85.91% 85.91%
=======================================
Files 39 39
Lines 1818 1818
=======================================
Hits 1562 1562
Misses 256 256
Continue to review full report at Codecov.
|
Thanks for this @CasperWA! I've just added the same test on our default I'll approve this and you can merge, unless you see any issues with my changes. |
07f8be7
to
e9d1c98
Compare
Don't see any problems, only - why not use the actual |
Could do, I just figured having a separate test file might be helpful if we make any changes to the default. I'll leave it up to you! |
This function did not work properly.
Add test file for config.py, for now only with a simple test to run
load_from_json()
.Feel free to add more tests to
test_config.py
either in this PR or later.