Add database page limit #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
+ Coverage 86.12% 86.18% +0.06%
==========================================
Files 39 39
Lines 1816 1824 +8
==========================================
+ Hits 1564 1572 +8
Misses 252 252
Continue to review full report at Codecov.
|
CasperWA
force-pushed
the
add_db_page_limit
branch
from
a1481ea
to
2cc22ee
Compare
ltalirz
reviewed
Jan 20, 2020
optimade/server/entry_collections.py
Outdated
| ) | ||
| if limit == 0: | ||
| limit = self.page_limit | ||
| limit = CONFIG.page_limit |
There was a problem hiding this comment.
is this necessary?
what if limit < 0?
If people explicitly request 0 entries, I'd say they should get 0 entries
There was a problem hiding this comment.
what if limit < 0?
This is handled by the QueryParams, i.e., all query parameter of page_* are NonNegativeInt types.
There was a problem hiding this comment.
But I guess we could put in another check, although it shouldn't be necessary?
Update handling of `page_limit` in `_parse_params()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the concept a maximum database limit to what the database will return in a single request.
Essentially it sets a maximum limit for the
page_limitquery parameter.This makes the page_limit concept from the config files a default page_limit.
Note: This is based on the work from #137, so this should not be merged before that PR, and should be merged via "Rebase and merge".