Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that checks whether client can find at least one base URL #1849

Merged
merged 1 commit into from Nov 5, 2023

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Nov 5, 2023

This has potential to be flaky if the providers list is down, but think that is a slim chance and this would have caught the previous issue in #1848.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #1849 (edf65c8) into master (2970d9a) will increase coverage by 0.69%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1849      +/-   ##
==========================================
+ Coverage   90.53%   91.22%   +0.69%     
==========================================
  Files          75       75              
  Lines        4627     4629       +2     
==========================================
+ Hits         4189     4223      +34     
+ Misses        438      406      -32     
Flag Coverage Δ
project 91.22% <100.00%> (+0.69%) ⬆️
validator 90.68% <100.00%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
optimade/client/client.py 87.14% <ø> (-0.05%) ⬇️
optimade/utils.py 91.20% <100.00%> (+35.52%) ⬆️

... and 1 file with indirect coverage changes

@ml-evs ml-evs merged commit 55e2dd0 into master Nov 5, 2023
11 checks passed
@ml-evs ml-evs deleted the ml-evs/add_client_get_test branch November 5, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant