Create template filtertransformer BaseTransformer #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/base_transformer
branch
from
8066493
to
59d693e
Compare
Closed
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 92.20% 93.27% +1.06%
==========================================
Files 61 60 -1
Lines 3246 3256 +10
==========================================
+ Hits 2993 3037 +44
+ Misses 253 219 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
The |
ml-evs
force-pushed
the
ml-evs/base_transformer
branch
2 times, most recently
from
c920645
to
d5d2928
Compare
ml-evs
force-pushed
the
ml-evs/base_transformer
branch
5 times, most recently
from
a832c7f
to
0703397
Compare
ml-evs
force-pushed
the
ml-evs/base_transformer
branch
from
0703397
to
9d0918e
Compare
ml-evs
added
blocking
ml-evs
force-pushed
the
ml-evs/base_transformer
branch
from
9d0918e
to
ae05c78
Compare
- Raise deprecation warning for DjangoTransformer - Removed debug/json transformers - Tweaked basetransformer docstrings
ml-evs
force-pushed
the
ml-evs/base_transformer
branch
from
ae05c78
to
b8cc2aa
Compare
4 tasks
CasperWA
reviewed
Dec 4, 2020
There was a problem hiding this comment.
Looking good, thanks @ml-evs!
Are there any actual changes in the grammar?
I think "Return as is." is more telling than "Do nothing!" - so I have suggested this change everywhere. There are also some other comments, but only suggestions.
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
CasperWA
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first pass at a
BaseTransformer. I think we need to discuss what to do with the Django, JSON and TransformerSkeleton and elasticsearch transformers, plus all the grammar variants... I haven't really gotten my head around how lark interacts with these magic-word methods, and how we currently have different method names between al the transformers.For now, I've made most of the
BaseTransformermethods abstract, apart from those that do very simple things (i.e. take in a value and return value).Lark2Django/DjangoTransformer, which is working from 0.9.7 grammar and will be tricky to adaptJSONTransformerandDebugTransformer(and updated docs)BaseTransformerand pulled mongo functionality outv1.0.0grammar that links tov0.10.1