Update elasticsearch transformer to v1 grammar use BaseTransformer #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
the
transformer/Elasticsearch
ml-evs
added
the
blocked
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 93.27% 93.31% +0.03%
==========================================
Files 60 61 +1
Lines 3257 3304 +47
==========================================
+ Hits 3038 3083 +45
- Misses 219 221 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4 tasks
ml-evs
removed
the
blocked
ml-evs
force-pushed
the
ml-evs/rebasing_elasticsearch
branch
from
508dfb6
to
4df420c
Compare
ml-evs
force-pushed
the
ml-evs/rebasing_elasticsearch
branch
2 times, most recently
from
cbfa042
to
eecf436
Compare
…e review Co-authored-by: Casper Welzel Andersen <casper.andersen@epfl.ch>
ml-evs
force-pushed
the
ml-evs/rebasing_elasticsearch
branch
from
eecf436
to
3bebc72
Compare
ml-evs
force-pushed
the
ml-evs/rebasing_elasticsearch
branch
from
3bebc72
to
c6afdd9
Compare
ml-evs
changed the title
|
As this PR was initially reviewed by @CasperWA and myself and written by @markus1978 over at #309, with only tests and restructuring added by me in this PR, I think I'll merge it later today so we have a stable base to work on promoting elasticsearch as a fully-fledged backend. |
ml-evs
added a commit
that referenced
this pull request
Dec 30, 2020
) * Adapted the elastic transformer for the v0.10.1 grammar. Co-authored-by: Markus Scheidgen <markus.scheidgen@gmail.com> * Renaming of elastic transformer class, minor fixes and typos from code review Co-authored-by: Casper Welzel Andersen <casper.andersen@epfl.ch> * Rebased elasticsearch onto new BaseTransformer and update tests Co-authored-by: Markus Scheidgen <markus.scheidgen@gmail.com> Co-authored-by: Casper Welzel Andersen <casper.andersen@epfl.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by (and currently contains commits from #286), and supersedes #309 by updating the elasticsearch transformer to work with the final v1.0.0 grammar.
The aim beyond this PR is then to move some of the handling of e.g. aliases and field types into the base transformer so that all transformers can benefit.