Decouple changes in providers repo #312
Conversation
shyamd
changed the title
# Conflicts: # .github/workflows/deps_eager.yml # tests/test_setup.py
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
- Coverage 90.92% 90.92% -0.01%
==========================================
Files 54 54
Lines 2336 2335 -1
==========================================
- Hits 2124 2123 -1
Misses 212 212
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I have one comment about the frequency of checks, related to my question below, but otherwise happy to accept.
Is there a way to only trigger dependabot if the providers.json file itself changes? The providers repo is also used to host some infrastructure (via netlify), and although it doesn't seem to change much, it would be good to not have to review the PR to find out whether the changes are relevant for us.
.github/dependabot.yml
Outdated
| - package-ecosystem: submodules | ||
| directory: "/" | ||
| schedule: | ||
| interval: weekly |
There was a problem hiding this comment.
| interval: weekly | |
| interval: weekly |
I reckon we could make this one daily? We're never going to decline it and it would be good for clients that are continuously deploying this package to remain up to date.
|
@ml-evs , it looks like there is no way for dependabot to just watch a file in a submodule for now. We could switch this so that we just keep the sub-module tracked with master, but that could also introduce an unforeseen breaking change which I what I'm trying to avoid. |
Understood, it's fine as is for me. |
Fix #311
This incorporates the
providersdata as a sub-module to decouple it.