-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple changes in providers repo #312
Merged
shyamd
merged 19 commits into
Materials-Consortia:master
from
shyamd:fix-311-decouple-providers
Jun 25, 2020
Merged
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
bede37d
Add providers submodule
shyamd 22f8574
use submodule providers rather then optimade url
shyamd 3b8e1f3
check providers file in sdist
shyamd 48e4d7f
checkout submodules
shyamd ed4b862
Merge branch 'master' into fix-311-decouple-providers
shyamd a52b92c
fix submodules key
shyamd ffdab73
update providers
shyamd 0cf005a
add submodules to dependabot
shyamd 0089e06
don't lint the submodule
shyamd 0c9b330
Merge branch 'master' into fix-311-decouple-providers
shyamd 2b88300
fix dockerfile
shyamd 8384a5c
Merge branch 'master' into fix-311-decouple-providers
shyamd 8e40240
Merge branch 'master' into fix-311-decouple-providers
shyamd c9f3d61
Merge branch 'master' into fix-311-decouple-providers
shyamd 159273e
Merge branch 'master' into fix-311-decouple-providers
shyamd c1ea165
Merge branch 'master' into fix-311-decouple-providers
shyamd a5a70c5
switch to daily updatees
shyamd efd14f2
no need for reviewers since Github CI takes care of this
shyamd 3d6ac80
Merge branch 'master' into fix-311-decouple-providers
shyamd File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[submodule "providers"] | ||
path = providers | ||
url = git@github.com:Materials-Consortia/providers.git | ||
shyamd marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../../providers/providers.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ | |
"landing_page.html", | ||
"filters.txt", | ||
"optional_filters.txt", | ||
"providers.json", | ||
] | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reckon we could make this one daily? We're never going to decline it and it would be good for clients that are continuously deploying this package to remain up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.