Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Elasticsearch collection #339

Closed
wants to merge 10 commits into from

Conversation

markus1978
Copy link
Contributor

This is an ugly PR:

  • lots of changes, due to pulling lots of mongo specifics into entry_collections.mongo
  • it supersets the other PR on the elastic transformer
  • its still work-in-progress with no tests for the elastic implementation in the CI so far

Please have a look at the mongo stuff and let me know what you think.

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #339 into master will decrease coverage by 4.79%.
The diff coverage is 55.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   90.56%   85.76%   -4.80%     
==========================================
  Files          55       56       +1     
  Lines        2268     2438     +170     
==========================================
+ Hits         2054     2091      +37     
- Misses        214      347     +133     
Flag Coverage Δ
#unittests 85.76% <55.83%> (-4.80%) ⬇️
Impacted Files Coverage Δ
optimade/server/entry_collections/elasticsearch.py 0.00% <0.00%> (ø)
optimade/server/routers/utils.py 90.24% <ø> (-7.49%) ⬇️
...made/server/entry_collections/entry_collections.py 82.60% <60.00%> (-6.29%) ⬇️
optimade/filtertransformers/elasticsearch.py 89.28% <90.47%> (+1.54%) ⬆️
optimade/server/entry_collections/mongo.py 87.93% <94.73%> (+1.19%) ⬆️
optimade/server/config.py 100.00% <100.00%> (ø)
optimade/server/entry_collections/__init__.py 100.00% <100.00%> (ø)
optimade/server/main.py 84.78% <100.00%> (-0.94%) ⬇️
optimade/server/main_index.py 89.18% <100.00%> (-1.29%) ⬇️
optimade/server/routers/links.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3299b56...cfb8722. Read the comment docs.

@ml-evs
Copy link
Member

ml-evs commented Nov 26, 2020

Sorry for taking so long to deal with this @markus1978, this PR is now superseded by #613 which incorporates all the changes from this PR and also rebases onto the new base transformer.

@ml-evs ml-evs closed this Nov 26, 2020
@ml-evs
Copy link
Member

ml-evs commented Dec 24, 2020

Just realised that I closed this PR prematurely, apologies! I will be add the changes from this PR into a new PR after we have #613 merged. I will make sure to incorporate and credit your changes here @markus1978.

ml-evs added a commit that referenced this pull request Jan 5, 2021
Co-authored-by: Markus Scheidgen <markus.scheidgen@gmail.com>
ml-evs added a commit that referenced this pull request Jan 12, 2021
Co-authored-by: Markus Scheidgen <markus.scheidgen@gmail.com>
ml-evs added a commit that referenced this pull request Jan 20, 2021
Co-authored-by: Markus Scheidgen <markus.scheidgen@gmail.com>
ml-evs added a commit that referenced this pull request Mar 8, 2021
Co-authored-by: Markus Scheidgen <markus.scheidgen@gmail.com>
ml-evs added a commit that referenced this pull request Mar 8, 2021
Co-authored-by: Markus Scheidgen <markus.scheidgen@gmail.com>
CasperWA pushed a commit that referenced this pull request Mar 15, 2021
Co-authored-by: Markus Scheidgen <markus.scheidgen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants