Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies #551

Merged
merged 8 commits into from Oct 12, 2020
Merged

Updated dependencies #551

merged 8 commits into from Oct 12, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Oct 12, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #551   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files          62       62           
  Lines        3110     3110           
=======================================
  Hits         2845     2845           
  Misses        265      265           
Flag Coverage Δ
#project 91.47% <ø> (ø)
#validator 63.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004686c...3ff3c4c. Read the comment docs.

@ml-evs ml-evs requested a review from CasperWA October 12, 2020 10:10
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick test here seems like one won't get the latest version if the .1 is not included in setup.py as well.

setup.py Outdated Show resolved Hide resolved
@ml-evs ml-evs requested a review from CasperWA October 12, 2020 12:10
- pytest.importorskip(...) uses Packaging under the hood, so can accept
arbitrary versions
tests/adapters/structures/utils.py Outdated Show resolved Hide resolved
ml-evs and others added 2 commits October 12, 2020 14:15
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
@ml-evs ml-evs requested a review from CasperWA October 12, 2020 13:34
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @ml-evs

P.S.: No need to add me as co-author for this.

@ml-evs
Copy link
Member Author

ml-evs commented Oct 12, 2020

Cheers @ml-evs

P.S.: No need to add me as co-author for this.

👍

@ml-evs ml-evs merged commit 20d65f0 into master Oct 12, 2020
@ml-evs
Copy link
Member Author

ml-evs commented Oct 12, 2020

Cheers @ml-evs

P.S.: No need to add me as co-author for this.

👍

Didn't get a choice to remove you on mobile, if you're really ashamed you can edit the commit and force push to master...

@CasperWA CasperWA deleted the ml-evs/deps branch October 12, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants